Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML/View Template is rendered twice #16771

Closed
2 of 6 tasks
PhoenixPeca opened this issue Aug 22, 2021 · 1 comment · Fixed by #16794
Closed
2 of 6 tasks

HTML/View Template is rendered twice #16771

PhoenixPeca opened this issue Aug 22, 2021 · 1 comment · Fixed by #16794
Labels
type/bug
Milestone
1.15.1

Comments

@PhoenixPeca
Copy link

  • Gitea version (or commit ref): v1.15.0
  • Git version: not relevant
  • Operating system: Ubuntu (Gitee docker via mailcow setup)
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No -- the gitea server did not send me the activation link.
  • Log gist: not relevant

Description

I'm not sure if this issue has been reported already, but after researching the existing issues in this repo, seems like this is a new one.

Anyways... here's a bug that I found:

I'm using the latest release of Gitea (v1.15.0) and created a new empty repository. I opened the repository Settings and clicked on the "Add Push Mirror" button without any change to the other fields and somehow the webpage just reloads and renders two copies of the same template. Attached is the fullpage screenshot.

Screenshots

Fullpage PDF Screenshot: screencapture-mail-aspac-io-gitea-phoenix-testing-settings-2021-08-22-23_09_30.pdf

Fullpage PNG Screenshotimage
screencapture-mail-aspac-io-gitea-phoenix-testing-settings-2021-08-22-23_09_30.pdf
@delvh
Copy link
Member

delvh commented Aug 22, 2021

I would like to mention that these are not two exactly equal copies:
Copy one has as error message
You are not allowed to import local repositories, and copy two has
the provided url is invalid. You must escape all components of the URL correctly.
So, could it be that the copy behavior is triggered by two different error messages being present at once, and for each error message the site is created again?

@noerw noerw added the type/bug label Aug 23, 2021
@noerw noerw added this to the 1.15.1 milestone Aug 23, 2021
zeripath added a commit to zeripath/gitea that referenced this issue Aug 23, 2021
@zeripath
Add missing return to handleSettingRemoteAddrError
ae40589 
There is a missing return in handleSettingRemoteAddrError which means
that the error page for repo settings is duplicately rendered.

Fix go-gitea#16771

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Aug 23, 2021
Merged
zeripath added a commit to zeripath/gitea that referenced this issue Aug 23, 2021
@zeripath
Add missing return to handleSettingRemoteAddrError (go-gitea#16794)
ec6875f 
Backport go-gitea#16794

There is a missing return in handleSettingRemoteAddrError which means
that the error page for repo settings is duplicately rendered.

Fix go-gitea#16771

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Aug 23, 2021
Merged
techknowlogick added a commit that referenced this issue Aug 23, 2021
@zeripath @techknowlogick
Add missing return to handleSettingRemoteAddrError (#16794)
921afb5 
There is a missing return in handleSettingRemoteAddrError which means
that the error page for repo settings is duplicately rendered.

Fix #16771

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
techknowlogick added a commit that referenced this issue Aug 23, 2021
@zeripath @techknowlogick
Add missing return to handleSettingRemoteAddrError (#16794) (#16795)
31e4e82 
Backport #16794

There is a missing return in handleSettingRemoteAddrError which means
that the error page for repo settings is duplicately rendered.

Fix #16771

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.15.1
Development

Successfully merging a pull request may close this issue.

Add missing return to handleSettingRemoteAddrError zeripath/gitea
3 participants
@noerw @PhoenixPeca @delvh