Milestone filter for pull requests shows either only open or closed milestones

[otbutz]

• Gitea version (or commit ref): 1.11.4
• Git version: 2.26.2
• Operating system: Ubuntu 18.04
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (https://try.gitea.io/otbutz99/broken-milestones/pulls)
  • No
  • Not relevant

Description

While browsing open PRs i'm only able to select open milestones in the filter and vice-versa. This way i'm unable to search for old PRs which targeted a milestone which is closed now or search for open PRs targeting a closed milestone.

The milestone filter should behave similar to the dropdown which is used to select the target milestone of a pull request. It should display all milestones but could provide a visual separation for open/closed ones:

Screenshots

In this case i'm unable to filter open PRs targeting v1.0.0 because it's a closed milestone.

Here i'm unable to filter PRs targeting milestone v4.0.0 which is still open.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[6543]

ping - still here

[dexterxx-pl]

+1

v1.13.2 still affected.

[otbutz]

@6543 the label kind/enhancement doesn't really fit. This is a bug.

[lunny]

So when filter on opened issues, we could just list opened milestones because closed milestones should not have opened issues. When filter on closed issues, we should list all milestones.

[otbutz]

closed milestones should not have opened issues

As long as i can close a milestone with open issues, i should be able to filter accordingly. And closing a milestone could be also interpreted as not accepting new issues.

[lunny]

That sounds not a normal operation, once closed a milestone, the first step you should do is to move open issues to other milestone.

Not list all the milestones here because some repositories have many milestones and most of them closed.

[dexterxx-pl]

The case is when you add new milestone while you already have some closed issues and you want to assign them to it.

Eg.

You're starting development without milestones
Closing some issues while still working eg. on v1.0
Then you realize that you need milestones and you create such one for our WIP v1.0 version.

Already filtered milestones might be displayed below that (of current state) oppened/closed... just to be able to use them if I want.