-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve milestone filter on issues page #22423
Conversation
Codecov Report
@@ Coverage Diff @@
## main #22423 +/- ##
==========================================
- Coverage 47.14% 46.99% -0.15%
==========================================
Files 1149 1163 +14
Lines 151446 153767 +2321
==========================================
+ Hits 71397 72265 +868
- Misses 71611 72985 +1374
- Partials 8438 8517 +79
... and 122 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor nit if we're going to change the translation keys anyways.
@delvh @jolheiser done. |
The other filters ( |
I think there is already a PR for |
No, the |
I mean #22640 |
…lunny/milestone_filter
if len(opts.MilestoneIDs) == 1 && opts.MilestoneIDs[0] == db.NoConditionID { | ||
sess.And("issue.milestone_id = 0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name NoConditionID
looks really strange. When reading the code:
- The parameter is no-condition-ID
- The the next line adds a condition .....
Just a nit, just my opinion, not blocker.
Now we have `All milestones`, `No milestones`, `Open milestones` and `Closed milestones`. Fix go-gitea#11924 Fix go-gitea#22411 <img width="1166" alt="image" src="https://user-images.githubusercontent.com/81045/212243375-95eea035-a972-44b8-8088-53db614cb07e.png">
Backport #22423 by @lunny Now we have `All milestones`, `No milestones`, `Open milestones` and `Closed milestones`. Fix #11924 Fix #22411 <img width="1166" alt="image" src="https://user-images.githubusercontent.com/81045/212243375-95eea035-a972-44b8-8088-53db614cb07e.png"> Co-authored-by: Lunny Xiao <[email protected]>
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [gitea/gitea](https://github.com/go-gitea/gitea) | patch | `1.19.2-rootless` -> `1.19.3-rootless` | --- ### Release Notes <details> <summary>go-gitea/gitea</summary> ### [`v1.19.3`](https://github.com/go-gitea/gitea/blob/HEAD/CHANGELOG.md#​1193-httpsgithubcomgo-giteagiteareleasestag1193---2023-05-03) [Compare Source](go-gitea/gitea@v1.19.2...v1.19.3) - SECURITY - Use golang 1.20.4 to fix CVE-2023-24539, CVE-2023-24540, and CVE-2023-29400 - ENHANCEMENTS - Enable whitespace rendering on selection in Monaco ([#​24444](go-gitea/gitea#24444)) ([#​24485](go-gitea/gitea#24485)) - Improve milestone filter on issues page ([#​22423](go-gitea/gitea#22423)) ([#​24440](go-gitea/gitea#24440)) - BUGFIXES - Fix api error message if fork exists ([#​24487](go-gitea/gitea#24487)) ([#​24493](go-gitea/gitea#24493)) - Fix user-cards format ([#​24428](go-gitea/gitea#24428)) ([#​24431](go-gitea/gitea#24431)) - Fix incorrect CurrentUser check for docker rootless ([#​24435](go-gitea/gitea#24435)) - Getting the tag list does not require being signed in ([#​24413](go-gitea/gitea#24413)) ([#​24416](go-gitea/gitea#24416)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42Ni4zIiwidXBkYXRlZEluVmVyIjoiMzUuNjYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: Michael Wittig <[email protected]> Reviewed-on: https://gitea.sh4ke.rocks/sh4ke/k8s-projects/pulls/178
Now we have
All milestones
,No milestones
,Open milestones
andClosed milestones
.Fix #11924
Fix #22411