Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed UI Improvements #27356

Merged
merged 3 commits into from
Sep 30, 2023
Merged

Feed UI Improvements #27356

merged 3 commits into from
Sep 30, 2023

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Sep 29, 2023

Various improvements related to feeds:

  • Fix markdown rendering
  • Increase font size from 13px to default 14px via flex-item
  • Add style to hashes
  • Move the timestamp to title line. I realize it's not optimal for translation, we may need to change all these translations

Before:
Screenshot 2023-09-29 at 22 52 58

After:
Screenshot 2023-09-29 at 22 58 09

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 29, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 29, 2023
@github-actions github-actions bot added the topic/ui Change the appearance of the Gitea UI label Sep 29, 2023
@silverwind silverwind added the type/enhancement An improvement of existing functionality label Sep 29, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 30, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2023
@6543 6543 added this to the 1.22.0 milestone Sep 30, 2023
@6543 6543 enabled auto-merge (squash) September 30, 2023 15:12
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 30, 2023
@6543 6543 merged commit 83f5716 into go-gitea:main Sep 30, 2023
25 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Sep 30, 2023
@silverwind silverwind deleted the feed branch September 30, 2023 22:38
silverwind added a commit that referenced this pull request Oct 7, 2023
@denyskon denyskon added the backport/v1.21 This PR should be backported to Gitea 1.21 label Oct 20, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 21, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 21, 2023
Various improvements related to feeds:

- Fix markdown rendering
- Increase font size from 13px to default 14px via `flex-item`
- Add style to hashes
- Move the timestamp to title line. I realize it's not optimal for
translation, we may need to change all these translations

Before:
<img width="768" alt="Screenshot 2023-09-29 at 22 52 58"
src="https://github.com/go-gitea/gitea/assets/115237/edda8b84-23cf-4a43-90ad-a892798f4e6c">

After:
<img width="781" alt="Screenshot 2023-09-29 at 22 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/7097474d-efcf-4f22-a2ab-834a4e25c4e8">
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 21, 2023
silverwind added a commit that referenced this pull request Oct 21, 2023
Backport #27498 by @silverwind

1. Improve various feed icons
2. Fix merge message color


<img width="763" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/3f5bcb23-6d90-4c63-85f2-46bd7e1c96d6">
<img width="769" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/466c37b4-e2f4-42bb-922d-b86596cdc6d0">


Fixes: #27495
Continues: #27356

Co-authored-by: silverwind <[email protected]>
silverwind added a commit that referenced this pull request Oct 21, 2023
Backport #27356 by @silverwind

Various improvements related to feeds:

- Fix markdown rendering
- Increase font size from 13px to default 14px via `flex-item`
- Add style to hashes
- Move the timestamp to title line. I realize it's not optimal for
translation, we may need to change all these translations

Before:
<img width="768" alt="Screenshot 2023-09-29 at 22 52 58"
src="https://github.com/go-gitea/gitea/assets/115237/edda8b84-23cf-4a43-90ad-a892798f4e6c">

After:
<img width="781" alt="Screenshot 2023-09-29 at 22 58 09"
src="https://github.com/go-gitea/gitea/assets/115237/7097474d-efcf-4f22-a2ab-834a4e25c4e8">

Co-authored-by: silverwind <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants