Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translations on Milestones page sort dropdown #29778

Closed
silverwind opened this issue Mar 13, 2024 · 1 comment · Fixed by #29785
Closed

Missing translations on Milestones page sort dropdown #29778

silverwind opened this issue Mar 13, 2024 · 1 comment · Fixed by #29785
Labels
good first issue Likely to be an easy fix type/bug
Milestone
1.21.9

Comments

@silverwind
Copy link
Member

silverwind commented Mar 13, 2024 •
edited
Loading

Description

Open https://try.gitea.io/milestones, click "Sort":

image

The tokens repo.milestones.filter_sort.closest_due_date and repo.milestones.filter_sort.furthest_due_date do not appear in options/locale/locale_en-US.ini currently, maybe they got lost somehow, I wasn't able to determine what exactly happend, but they should be re-added.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes
@silverwind silverwind added type/bug good first issue Likely to be an easy fix labels Mar 13, 2024
@silverwind silverwind added this to the 1.21.9 milestone Mar 14, 2024
@silverwind
Copy link
Member Author

Bug also exists on 1.21.

@lunny lunny mentioned this issue Mar 14, 2024
Merged
lunny added a commit that referenced this issue Mar 14, 2024
@lunny
Fix missing translation on milestons (#29785)
8d979f1 
Caused by #26569
Fix #29778
GiteaBot pushed a commit to GiteaBot/gitea that referenced this issue Mar 14, 2024
@lunny @GiteaBot
Fix missing translation on milestons (go-gitea#29785)
0a72aa4 
Caused by go-gitea#26569
Fix go-gitea#29778
@GiteaBot GiteaBot mentioned this issue Mar 14, 2024
Merged
silverwind pushed a commit that referenced this issue Mar 14, 2024
@GiteaBot @lunny
Fix missing translation on milestons (#29785) (#29789)
e03cf66 
Backport #29785 by @lunny

Caused by #26569
Fix #29778

Co-authored-by: Lunny Xiao <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Likely to be an easy fix type/bug
Projects
None yet
Milestone
1.21.9
Development

Successfully merging a pull request may close this issue.

Fix missing translation on milestons lunny/gitea
1 participant
@silverwind