Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing translation on milestons #29785

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Fix missing translation on milestons #29785

merged 2 commits into from
Mar 14, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 14, 2024

Caused by #26569
Fix #29778

@lunny lunny added the type/bug label Mar 14, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 14, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 14, 2024
@lunny lunny added backport/v1.21 This PR should be backported to Gitea 1.21 and removed modifies/templates This PR modifies the template files labels Mar 14, 2024
wxiaoguang
wxiaoguang approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the typo to make it backportable ....

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 14, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 14, 2024
@wolfogre wolfogre added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 14, 2024
@lunny lunny enabled auto-merge (squash) March 14, 2024 07:14
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Mar 14, 2024
@lunny lunny merged commit 8d979f1 into go-gitea:main Mar 14, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 14, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 14, 2024
@lunny @GiteaBot
Fix missing translation on milestons (go-gitea#29785)
0a72aa4 
Caused by go-gitea#26569
Fix go-gitea#29778
@GiteaBot GiteaBot mentioned this pull request Mar 14, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 14, 2024
silverwind pushed a commit that referenced this pull request Mar 14, 2024
@GiteaBot @lunny
Fix missing translation on milestons (#29785) (#29789)
e03cf66 
Backport #29785 by @lunny

Caused by #26569
Fix #29778

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 14, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
e148c28 
* giteaofficial/main:
  Support GITEA_I_AM_BEING_UNSAFE_RUNNING_AS_ROOT env (go-gitea#29788)
  Fix missing translation on milestons (go-gitea#29785)
  Fix lint-swagger warning (go-gitea#29787)
  Tweak actions view sticky (go-gitea#29781)
  add skip ci support for pull request title (go-gitea#29774)
  Refactor markup/csv: don't read all to memory (go-gitea#29760)
@6543 6543 modified the milestones: 1.23.0, 1.22.0 Mar 16, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

Missing translations on Milestones page sort dropdown
5 participants
@lunny @wxiaoguang @wolfogre @GiteaBot @6543