Prevent NPE on commenting on lines with invalidated comments (#12549) #12550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only check for a review if we are replying to a previous review. Prevent the NPE in go-gitea#12239 by assuming that a comment without a Review is non-pending. Fix go-gitea#12239 Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
zeripath
changed the title
zeripath
added
type/bug
issue/critical
mrsdizzie
approved these changes
Aug 20, 2020
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Aug 21, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport (ish) of #12549 . This is a rebase of #12548 on 1.12 and represents a working fix for #12239 without the migration in #12549 that makes the template changes unnecessary.
#12239 reports an NPE when viewing the diff page of a PR when comments are made on a line that has previously had comments invalidated on it.
@mrsdizzie discovered the mechanism and reason this occurs.
This PR fixes the above NPE by setting a comment without Review to Comment Type.
It prevents a review being assigned to 0 by only checking for a review if we are replying to a previous review.
Finally it adds a section into the comments template to show these reviewless comments.
Fix #12239
Signed-off-by: Andrew Thornton [email protected]