Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE on commenting on lines with invalidated comments (#12549) #12550

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Prevent NPE on commenting on lines with invalidated comments (#12549) #12550

merged 2 commits into from
Aug 21, 2020

Commits on Aug 20, 2020

  1. Prevent NPE on commenting on lines with invalidated comments 

    Only check for a review if we are replying to a previous review.

Prevent the NPE in go-gitea#12239 by assuming that a comment without a Review is
non-pending.

Fix go-gitea#12239

Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    9fe8a89 View commit details
    Browse the repository at this point in the history

  2. Add hack around to show the broken comments 

    Signed-off-by: Andrew Thornton <[email protected]>
    @zeripath
    zeripath committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6e90f59 View commit details
    Browse the repository at this point in the history