Make bindata.go optional, remove from repository #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Keep this open til #74 is merged, so people can use this before the other fix is done. |
bkcsoft
added
type/enhancement
Current coverage is 3.25% (diff: 31.25%)@@ master #172 diff @@
========================================
Files 33 34 +1
Lines 8106 8170 +64
Methods 0 0
Messages 0 0
Branches 0 0
========================================
+ Hits 246 266 +20
- Misses 7840 7881 +41
- Partials 20 23 +3
|
strk
force-pushed
the
optional-bindata
branch
4 times, most recently
from
8213590
to
9184ca6
Compare
strk
force-pushed
the
optional-bindata
branch
3 times, most recently
from
8333ffc
to
3d14719
Compare
tboerger
added
the
lgtm/need 2
strk
force-pushed
the
optional-bindata
branch
5 times, most recently
from
25ceda1
to
5ff07a9
Compare
strk
force-pushed
the
optional-bindata
branch
3 times, most recently
from
b324f98
to
8f6c1e8
Compare
By default will read assets from filesystems, but can embed them by passing the "bindata" build tag (go build -tags bindata) Fixes gogs#77 Print a WARNING when bindata is not embedded, and honours GITEA_WORK_DIR, when given, for finding filesystem assets. Include automatic test for the dynamic "bin"data library
strk
force-pushed
the
optional-bindata
branch
from
8f6c1e8
to
c155be7
Compare
|
Obsoleted via #354 |
tboerger
removed
type/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default will read assets from filesystems, but can embed them
by passing the "bindata" build tag (go build -tags bindata)
Fixes #30
Print a WARNING when bindata is not embedded, and
honours GITEA_WORK_DIR, when given, for finding filesystem assets.
Includes automatic test for the dynamic "bin"data library.
NOTE: an equivalent functionality is planned to be included in a
bigger change by @tboerger currently in progress and tracked as PR #74;
this PR is smaller in scope and ready.
Please keep open until either this or #74 is merged.