Integrated bindata for public and templates

[tboerger]

Fixes #30

Things left to do:

• Integrate the switch for mailer templates
• Make conf also aware of builtin or external

[lunny]

LGTM

[strk]

Does public/ already support override via custom/public?
As I think I'm using public/img to store custom logo and favicon...

[thibaultmeyer]

I think bindata.go dont have to be committed on repository and must be auto-generated during the make process.

It become a mess when two (or more) Pull Requests update different files (eg : app.ini for the first commit and add new files for the second) because the bindata.go file cause merge error each time.

[strk]

I tend to agree with @0xBAADF00D but would rather avoid blocking this change due to that issue. Rather, I suggest a new issue is filed for the bindata.go threatment.

[tboerger]

I'm currently thinking about rebuilding the bindata interface that handles static directories instead of embedding the data, switched via a build tag.

[codecov-io]

Current coverage is 2.18% (diff: 0.00%)

Merging #74 into master will not change coverage

@@            master       #74   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update 91b589f...b58e8fc

[andreynering]

@tboerger I don't know if it helps you, but I like fileb0x because it prevents the need of two different tools: bindata and bindata-assetfs.

Also, bindata-assetfs has this bug on Windows.

[bkcsoft]

@andreynering +1 on not using go-bindata-assets WRT elazarl/go-bindata-assetfs#34 (comment)

One of the reasons I'm not putting too much effort in this project, is
because there are better alternative available.

[tboerger]

fileb0x won't work because we rely on tags with the new bindata.

[bkcsoft]

Does Rice? https://github.com/GeertJohan/go.rice

[tboerger]

I will avaluate it with go.rice, looks like it also supports loading from a directory natively.

[andreynering]

@tboerger

I will evaluate it with go.rice, looks like it also supports loading from a directory natively.

Like this? UnnoTed/fileb0x#3

Just trying to help, I'm fine with any option 👍

[tboerger]

@andreynering currently we want to embed the data optionally via a build tag, bindata builds all assets into the binary while !bindata always reads the assets from the filesystem.

[andreynering]

You're right, this would not be possible using fileb0x and build tags.

A workaroud would be having two fileb0x files ( fileb0x-debug.yml and fileb0x.yml) and two distinct commands on makefile to build with one or other option.

But if rice supports build tags, it would be way simpler.

[tboerger]

Obsolete via #354 #314 #293