Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly flush unique queues on startup (#23154) #23200

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Properly flush unique queues on startup (#23154) #23200

merged 2 commits into from
Mar 6, 2023

Commits on Feb 28, 2023

  1. Properly flush unique queues on startup (go-gitea#23154) 

    There have been a number of reports of PRs being blocked whilst being
checked which have been difficult to debug. In investigating go-gitea#23050 I
have realised that whilst the Warn there is somewhat of a miscall there
was a real bug in the way that the LevelUniqueQueue was being restored
on start-up of the PersistableChannelUniqueQueue.

Next there is a conflict in the setting of the internal leveldb queue
name - This wasn't being set so it was being overridden by other unique
queues.

This PR fixes these bugs and adds a testcase.

Thanks to @brechtvl  for noticing the second issue.

Fix go-gitea#23050
and others

---------

Signed-off-by: Andrew Thornton <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
    @zeripath @techknowlogick @GiteaBot
    2 people authored and GiteaBot committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    836a3a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'release/v1.18' into backport-23154-v1.18

    @delvh
    delvh authored Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0af8c95 View commit details
    Browse the repository at this point in the history