Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SVG in dropdown menu have the same margin-right as IMG #24316

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Make SVG in dropdown menu have the same margin-right as IMG #24316

merged 3 commits into from
Apr 25, 2023

Conversation

wxiaoguang
Copy link
Contributor

Fix #24226

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2023
@GiteaBot GiteaBot added this to the 1.20.0 milestone Apr 25, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2023
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Apr 25, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2023
@silverwind silverwind enabled auto-merge (squash) April 25, 2023 06:35
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@silverwind
Copy link
Member

I thought I had fixed this before, there might be a lingering style somewhere for it.

@silverwind
Copy link
Member

Original fix was https://github.com/go-gitea/gitea/pull/21890/files#diff-5d1373f9290f762a4751c497b0e8be279eb04caa3a7cdc2fd3f42b9f505a83be, I wonder what became of that rule 😆

@silverwind
Copy link
Member

silverwind commented Apr 25, 2023 •
edited
Loading

Might have been some unintended deletion of the rule, I don't see it any more in the space where it should be in the CSS and this PR adds it back at the same place.

@silverwind silverwind enabled auto-merge (squash) April 25, 2023 11:09
@silverwind silverwind merged commit f16b668 into go-gitea:main Apr 25, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 25, 2023
@wxiaoguang wxiaoguang deleted the fix-dropdown-svg branch April 25, 2023 11:35
@wxiaoguang
Copy link
Contributor Author

I guess because there is no comment and svg.img seems a misspell ... maybe it's me who deleted that style .....

@silverwind
Copy link
Member

Match via svg is better anyways, no idea why I added .img class.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
3be44b5 
* giteaofficial/main:
  Fix broken clone script on an empty archived repo (go-gitea#24339)
  Improve RSS (go-gitea#24335)
  Automatically select the org when click create repo from org dashboard (go-gitea#24325)
  on schedule
  on schedule
  switch to use Actions from drone for cron (go-gitea#24314)
  [skip ci] Updated translations via Crowdin
  Restore bold on repolist (go-gitea#24337)
  Fix template function DateTime (go-gitea#24317)
  Fix incorrect CORS response in Http Git handler (go-gitea#24303)
  Updated upgrade script that is informing user that Gitea service has to be running in order to upgrade it (go-gitea#24260)
  Add tags list for repos whose release setting is disabled (go-gitea#23465)
  Refactor config provider (go-gitea#24245)
  Add RSS Feeds for branches and files (go-gitea#22719)
  Make SVG in dropdown menu have the same margin-right as IMG (go-gitea#24316)
  Respect the REGISTER_MANUAL_CONFIRM setting when registering via OIDC (go-gitea#24035)
@wxiaoguang wxiaoguang added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 2, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@Zettat123 Zettat123 Zettat123 approved these changes

@yardenshoham yardenshoham yardenshoham approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.

Incorrect icon position in Add Webhook dropdown
6 participants
@wxiaoguang @silverwind @techknowlogick @Zettat123 @yardenshoham @GiteaBot