Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SSH_AUTHORIZED_KEYS_BACKUP to false #25412

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jun 21, 2023

This prevents disk from overflowing with auth keys file

Fixes #17117

⚠️ BREAKING

This changes the default option for creating a backup of the authorized key file when an update is made to default to false.

This prevents disk from overflowing with auth keys file
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 21, 2023
@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Jun 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2023
@lunny lunny added pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2023
@lunny lunny added this to the 1.21.0 milestone Jun 21, 2023
@lonix1
Copy link
Contributor

lonix1 commented Jun 21, 2023

Hi @techknowlogick and thanks.

I assume this sets SSH_AUTHORIZED_KEYS_BACKUP to false by default? So I can remove that from my code.

But the underlying infinite backups is still there? (Will surprise some people who don't know about it.)

@techknowlogick
Copy link
Member Author

@lonix1 that's correct on both assumptions, you wouldn't need to have the config option yourself as this would change the default, and also it doesn't truly fix the underlying issue of infinite backups but this is a bandaid until that can be done.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 26, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 1, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 1, 2023
@techknowlogick techknowlogick enabled auto-merge (squash) July 1, 2023 03:50
@techknowlogick techknowlogick merged commit 469d89b into go-gitea:main Jul 1, 2023
23 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 1, 2023
techknowlogick pushed a commit that referenced this pull request Jul 1, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 2, 2023
* giteaoffical/main: (89 commits)
  Move some files under repo/setting (go-gitea#25585)
  Following-up improvments for various PRs (go-gitea#25620)
  Set SSH_AUTHORIZED_KEYS_BACKUP to false (go-gitea#25412)
  Fix bug of branches API with tests (go-gitea#25578)
  [skip ci] Updated translations via Crowdin
  Application as a maintainer (go-gitea#25614)
  Adding  branch-name copy  to clipboard branches screen. (go-gitea#25596)
  Use AfterCommitId to get commit for Viewed functionality (go-gitea#25529)
  Fix branch commit message too long problem (go-gitea#25588)
  Restrict `[actions].DEFAULT_ACTIONS_URL` to only `github` or `self` (go-gitea#25581)
  Add API for changing Avatars (go-gitea#25369)
  read-only checkboxes don't appear and don't entirely act the way one might expect (go-gitea#25573)
  Redirect to package after version deletion (go-gitea#25594)
  Update emoji set to Unicode 15 (go-gitea#25595)
  Fix `lint-swagger` action (go-gitea#25593)
  Replace fomantic divider module with our own (go-gitea#25539)
  Add documentation about supported workflow trigger events (go-gitea#25582)
  Sync branches into databases (go-gitea#22743)
  Fix milestones deletion (go-gitea#25583)
  Reduce table padding globally (go-gitea#25568)
  ...

# Conflicts:
#	templates/repo/wiki/revision.tmpl
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No cleanup on authorized_keys file backups
5 participants