Fix branch commit message too long problem #25588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
added
skip-changelog
|
I am sure it works, but it's unclear when to use message summary. My suggestion: Now it's clear: 
|
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wolfogre
approved these changes
Jun 30, 2023
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Jun 30, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
@lunny backport? |
wxiaoguang
reviewed
Jul 1, 2023
| @@ -77,19 +77,19 @@ func SyncRepoBranchesWithRepo(ctx context.Context, repo *repo_model.Repository, | |||
| RepoID: repo.ID, | |||
| Name: branch, | |||
| CommitID: commit.ID.String(), | |||
| CommitMessage: commit.CommitMessage, | |||
There was a problem hiding this comment.
The meaning of "CommitMessage" in the branch struct has changed now.
If it's in main dev branch so there is still a chance to rename the field.
At least, there should be comment to say that it only contains the message summary but not the full message and why.
|
And, I am curious what why it's merged too fast. AFAIK, silverwind also complained that some PRs got merged too fast and suggested to wait for enough time after lgtm/done |
It cannot be backport because branch is 1.21 only feature |
techknowlogick
pushed a commit
that referenced
this pull request
Jul 1, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 2, 2023
* giteaoffical/main: (89 commits) Move some files under repo/setting (go-gitea#25585) Following-up improvments for various PRs (go-gitea#25620) Set SSH_AUTHORIZED_KEYS_BACKUP to false (go-gitea#25412) Fix bug of branches API with tests (go-gitea#25578) [skip ci] Updated translations via Crowdin Application as a maintainer (go-gitea#25614) Adding branch-name copy to clipboard branches screen. (go-gitea#25596) Use AfterCommitId to get commit for Viewed functionality (go-gitea#25529) Fix branch commit message too long problem (go-gitea#25588) Restrict `[actions].DEFAULT_ACTIONS_URL` to only `github` or `self` (go-gitea#25581) Add API for changing Avatars (go-gitea#25369) read-only checkboxes don't appear and don't entirely act the way one might expect (go-gitea#25573) Redirect to package after version deletion (go-gitea#25594) Update emoji set to Unicode 15 (go-gitea#25595) Fix `lint-swagger` action (go-gitea#25593) Replace fomantic divider module with our own (go-gitea#25539) Add documentation about supported workflow trigger events (go-gitea#25582) Sync branches into databases (go-gitea#22743) Fix milestones deletion (go-gitea#25583) Reduce table padding globally (go-gitea#25568) ... # Conflicts: # templates/repo/wiki/revision.tmpl
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When branch's commit CommitMessage is too long, the column maybe too short.(TEXT 16K for mysql).
This PR will fix it to only store the summary because these message will only show on branch list or possible future search?