-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove git.FileBlame
#25841
Merged
Merged
Remove git.FileBlame
#25841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfogre
added
the
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
label
Jul 12, 2023
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 12, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jul 12, 2023
techknowlogick
added
the
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
label
Jul 12, 2023
lunny
approved these changes
Jul 12, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 12, 2023
yardenshoham
approved these changes
Jul 12, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 12, 2023
delvh
approved these changes
Jul 12, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 12, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 12, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 14, 2023
* giteaofficial/main: Fix incorrect release count (go-gitea#25879) Add Github related extensions in devcontainer (go-gitea#25800) Add error info if no user can fork the repo (go-gitea#25820) Fix wrong usage of PathEscapeSegments in branch list page (go-gitea#25864) fix incorrect repo url when changed the case of ownername (go-gitea#25733) Upgrade go dependencies (go-gitea#25819) Don't stack PR tab menu on small screens (go-gitea#25789) Link to list of vulnerabilities (go-gitea#25872) [skip ci] Updated translations via Crowdin move issue filters to shared template (go-gitea#25729) [skip ci] Updated translations via Crowdin Remove `git.FileBlame` (go-gitea#25841) Fix empty project displayed in issue sidebar (go-gitea#25802) Update blog links (go-gitea#25843) Fix margin on the `new/edit milestone` page (go-gitea#25801) Do not "guess" the file encoding/BOM when using API to upload files (go-gitea#25828)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/refactoring
Existing code has been cleaned up. There should be no new functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FileBlame
function looks strange, it hasrevision
as argument but doesn't use it.Since the function never be used, I think we could just remove it.
If anyone thinks it should be kept, please help fix
revision
.