-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong usage of PathEscapeSegments in branch list page #25864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jul 13, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Jul 13, 2023
yp05327
changed the title
Fix wrong usage of DefaultBranchBranch in branch list page
Fix wrong usage of PathEscapeSegments in branch list page
Jul 13, 2023
lunny
approved these changes
Jul 13, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jul 13, 2023
lunny
added
type/bug
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
labels
Jul 13, 2023
puni9869
approved these changes
Jul 13, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jul 13, 2023
silverwind
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok if it works
lunny
added
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
and removed
backport/v1.20
This PR should be backported to Gitea 1.20
labels
Jul 14, 2023
I don't think this will affect v1.20, so I removed the backport label. |
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jul 14, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 14, 2023
* giteaofficial/main: Fix incorrect release count (go-gitea#25879) Add Github related extensions in devcontainer (go-gitea#25800) Add error info if no user can fork the repo (go-gitea#25820) Fix wrong usage of PathEscapeSegments in branch list page (go-gitea#25864) fix incorrect repo url when changed the case of ownername (go-gitea#25733) Upgrade go dependencies (go-gitea#25819) Don't stack PR tab menu on small screens (go-gitea#25789) Link to list of vulnerabilities (go-gitea#25872) [skip ci] Updated translations via Crowdin move issue filters to shared template (go-gitea#25729) [skip ci] Updated translations via Crowdin Remove `git.FileBlame` (go-gitea#25841) Fix empty project displayed in issue sidebar (go-gitea#25802) Update blog links (go-gitea#25843) Fix margin on the `new/edit milestone` page (go-gitea#25801) Do not "guess" the file encoding/BOM when using API to upload files (go-gitea#25828)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
skip-changelog
This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
emmm, don't know how to write a good title to describe this issue.
If you have a good idea, I can change the title.
The fix code is copied from L122. Not sure it is right or not.
@lunny
Maybe
DefaultBranchBranch
is also typo?Two
Branch
in variable name .