Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate public as bindata optionally #293

Merged
merged 11 commits into from
Nov 29, 2016
Merged

Integrate public as bindata optionally #293

merged 11 commits into from
Nov 29, 2016

Conversation

tboerger
Copy link
Member

Since there have been people crying because of the big bindata PR I'm trying to split it into multiple smaller pull requests. This is the first step which embeds the public folder optionally into the binary with the build tag bindata. This pull requests obsoletes parts of #74.

@metalmatze
Copy link
Contributor

I thought this was a huge PR, but then I saw all the /vendor diffs 😄

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 28, 2016
@Bwko
Copy link
Member

Bwko commented Nov 28, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Nov 28, 2016

Which package is pulling in BoltDB and EtcD? o.O

@tboerger
Copy link
Member Author

I think boltdb is a missing dependency for tidb, etcd I have not checked.

@lunny
Copy link
Member

lunny commented Nov 29, 2016

Why put go files in public dir? I think only static files could be put in it.

@tboerger
Copy link
Member Author

Then we should also move all assets into another subfolder

@lunny
Copy link
Member

lunny commented Nov 29, 2016

Why? And another thing, now all the golint pass except bindata.go maybe we should ignore the file?

@tboerger
Copy link
Member Author

Because of package name

@tboerger tboerger added this to the 1.0.0 milestone Nov 29, 2016
@tboerger
Copy link
Member Author

So what's up with it now? I would build the other bindata changes based on that.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 29, 2016
@tboerger
Copy link
Member Author

Ha, I will try to move the .go files to modules.

@tboerger
Copy link
Member Author

I have moved the bindata now into modules/public/ and updated the web cmd as well. This should be fine now, including optional bindata.

@bkcsoft
Copy link
Member

bkcsoft commented Nov 29, 2016

LGTM :)

@lunny lunny merged commit b6a95a8 into go-gitea:master Nov 29, 2016
@tboerger tboerger deleted the public-bindata branch November 29, 2016 18:08
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants