Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment in actions right view #29979

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Fix alignment in actions right view #29979

merged 8 commits into from
Mar 26, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Mar 22, 2024

Fixes: #29974, Regression from #29640.

Depending on the number of steps on the left side, the right side will vertically expand. Collapse it with align-self.

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 22, 2024
@silverwind silverwind changed the title Fix missing background in actions right view Fix alignment in actions right view Mar 22, 2024
@lunny
Copy link
Member

lunny commented Mar 22, 2024

Can you also fix the border-radius in the light theme?

image

@silverwind
Copy link
Member Author

Can you also fix the border-radius in the light theme?
image

Fixed in 0148874, now the background and border-radius are always on the same element.

@silverwind silverwind requested a review from lunny March 23, 2024 15:16
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 26, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2024
@lunny lunny enabled auto-merge (squash) March 26, 2024 07:47
@lunny lunny merged commit a4455d3 into go-gitea:main Mar 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 26, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2024
@silverwind silverwind deleted the actionbg branch March 26, 2024 09:36
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 26, 2024
* origin/main:
  Remove jQuery `.attr` from the Fomantic modal cancel buttons (go-gitea#30113)
  Remove jQuery `.attr` from the code comments (go-gitea#30112)
  Remove jQuery calls that have no effect on `showElem` and `hideElem` (go-gitea#30110)
  Remove jQuery `.attr` from the common issue page functions (go-gitea#30083)
  Restore aligned grid column CSS (go-gitea#30106)
  Fix possible data race on tests (go-gitea#30093)
  Add svg linter and fix incorrect svgs (go-gitea#30086)
  Fix duplicate migrated milestones (go-gitea#30102)
  Update JS any PY dependencies, remove workarounds (go-gitea#30085)
  Fix gitea doctor will remove repo-avatar files when execute command `storage-archives` (go-gitea#30094)
  Fix alignment in actions right view (go-gitea#29979)
  Remove repetitive words (go-gitea#30091)
  Fix table header text-align (go-gitea#30084)
  Fix panic for `fixBrokenRepoUnits16961` (go-gitea#30068)
@techknowlogick techknowlogick removed this from the 1.23.0 milestone Mar 28, 2024
@techknowlogick techknowlogick added this to the 1.22.0 milestone Mar 28, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Actions UI broken
5 participants