Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add svg linter and fix incorrect svgs #30086

Merged
merged 6 commits into from
Mar 26, 2024
Merged

Add svg linter and fix incorrect svgs #30086

merged 6 commits into from
Mar 26, 2024

Conversation

silverwind
Copy link
Member

Fixes #30082.

Adds a new linter that searches for non-existant SVG images in templates. Output before the fix was:

$ make lint-templates
SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl
SVG "octicon-warning" not found, used in templates/devtest/flex-list.tmpl
SVG "octicon-markup" not found, used in templates/repo/diff/comment_form.tmpl
make: *** [Makefile:438: lint-templates] Error 1
Screenshot 2024-03-25 at 23 31 05

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 25, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/internal modifies/js labels Mar 25, 2024
@silverwind silverwind added type/bug and removed modifies/templates This PR modifies the template files modifies/internal modifies/js labels Mar 25, 2024
@silverwind silverwind mentioned this pull request Mar 25, 2024
Merged
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/internal modifies/js labels Mar 25, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 25, 2024
lafriks pushed a commit that referenced this pull request Mar 26, 2024
@silverwind
Fix incorrect SVGs (#30087)
03f29db 
Just the SVG fixes from #30086 for
v1.21 branch.
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 26, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2024
@silverwind silverwind enabled auto-merge (squash) March 26, 2024 10:53
@silverwind silverwind merged commit 2ab5f05 into go-gitea:main Mar 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 26, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 26, 2024
@silverwind silverwind deleted the lintsvg branch March 26, 2024 12:35
silverwind added a commit to silverwind/gitea that referenced this pull request Mar 26, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into coloris
c36d353 
* origin/main:
  Remove jQuery `.attr` from the Fomantic modal cancel buttons (go-gitea#30113)
  Remove jQuery `.attr` from the code comments (go-gitea#30112)
  Remove jQuery calls that have no effect on `showElem` and `hideElem` (go-gitea#30110)
  Remove jQuery `.attr` from the common issue page functions (go-gitea#30083)
  Restore aligned grid column CSS (go-gitea#30106)
  Fix possible data race on tests (go-gitea#30093)
  Add svg linter and fix incorrect svgs (go-gitea#30086)
  Fix duplicate migrated milestones (go-gitea#30102)
  Update JS any PY dependencies, remove workarounds (go-gitea#30085)
  Fix gitea doctor will remove repo-avatar files when execute command `storage-archives` (go-gitea#30094)
  Fix alignment in actions right view (go-gitea#29979)
  Remove repetitive words (go-gitea#30091)
  Fix table header text-align (go-gitea#30084)
  Fix panic for `fixBrokenRepoUnits16961` (go-gitea#30068)
@techknowlogick techknowlogick modified the milestones: 1.23.0, 1.22.0 Mar 28, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Apr 3, 2024
@silverwind @earl-warren
Fix incorrect SVGs (#30087)
9053778 
Just the SVG fixes from go-gitea/gitea#30086 for
v1.21 branch.

(cherry picked from commit 03f29db46dbaa4cacca875cfe6b1c0b012a93406)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal modifies/js modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/code-linting type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

When adding code comment the note suggesting markdown with octicon doesn't show the octicon
5 participants
@silverwind @lunny @delvh @techknowlogick @GiteaBot