Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #31185 try fix lfs download from bitbucket failed #31201

Merged
merged 11 commits into from
Jun 11, 2024
Merged

Fix #31185 try fix lfs download from bitbucket failed #31201

merged 11 commits into from
Jun 11, 2024

Conversation

Zoupers
Copy link
Contributor

@Zoupers Zoupers commented May 31, 2024

Fix #31185

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label May 31, 2024
@Zoupers
Copy link
Contributor Author

Zoupers commented May 31, 2024

Maybe I should try if combined Accept header like application/vnd.git-lfs+json;q=0.9, */*;q=0.8 could solve it, since the later one should be more universal.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 1, 2024
@Zoupers
Copy link
Contributor Author

Zoupers commented Jun 1, 2024

I have try the new Accept header, it works.

@Zoupers Zoupers requested a review from silverwind June 2, 2024 05:03
delvh
delvh reviewed Jun 3, 2024
View reviewed changes
modules/lfs/shared.go Outdated Show resolved Hide resolved
modules/lfs/transferadapter_test.go Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2024
@Zoupers Zoupers requested a review from delvh June 4, 2024 02:33
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 7, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Jun 11, 2024
@silverwind silverwind enabled auto-merge (squash) June 11, 2024 21:54
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 11, 2024
@silverwind silverwind merged commit e25d696 into go-gitea:main Jun 11, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 11, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Jun 11, 2024
@Zoupers @GiteaBot
Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-git…
d05f20e 
…ea#31201)

Fix go-gitea#31185
@GiteaBot GiteaBot mentioned this pull request Jun 11, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Jun 11, 2024
lafriks pushed a commit that referenced this pull request Jun 11, 2024
@GiteaBot @Zoupers
Fix #31185 try fix lfs download from bitbucket failed (#31201) (#31329)
758f84f 
Backport #31201 by @Zoupers

Fix #31185

Co-authored-by: Zoupers Zou <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 12, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
66bf728 
* giteaofficial/main:
  Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-gitea#31201)
  Enable `unparam` linter (go-gitea#31277)
  Make template `Iif` exactly match `if` (go-gitea#31322)
  update nix flake and add gofumpt (go-gitea#31320)
  code optimization (go-gitea#31315)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

git lfs mirror download request maybe shouldn't carry Accept
4 participants
@Zoupers @silverwind @delvh @GiteaBot