-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update nix flake and add gofumpt #31320
Conversation
Why add gofmpt? I thought we run it similarly to golangci-lint |
Hm, true. This does have the benefit of having it in path for IDEs, though (assuming it's started from the nix shell or integrates with it, I guess). I'm fine with it either way personally, I think |
because then the tooling does not need install it and i can easy invoke it to format my code |
But can you lock down its version that way? New versions might introduce formatting differences. |
well it should not but in this case we probably do want a version bumb anyway ... I would propose to let it stay untill we do notice a problem - and as i now actively use it more or less every day I would hit that fast |
I guess it'll be fine but if there is a way to version-lock at least some of these dependencies in this file to a certain version range, that'd be great. |
it already is via the flake.lock |
* giteaofficial/main: Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-gitea#31201) Enable `unparam` linter (go-gitea#31277) Make template `Iif` exactly match `if` (go-gitea#31322) update nix flake and add gofumpt (go-gitea#31320) code optimization (go-gitea#31315)
just nix flake maintinance