Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nix flake and add gofumpt #31320

Merged
merged 4 commits into from
Jun 11, 2024
Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 11, 2024

just nix flake maintinance

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 11, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 11, 2024
@6543 6543 requested a review from jolheiser June 11, 2024 11:13
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 11, 2024
flake.nix Outdated Show resolved Hide resolved
@6543 6543 requested a review from jolheiser June 11, 2024 13:37
@6543 6543 changed the title update nix flake and a nit update nix flake and add gofumpt Jun 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 11, 2024
@jolheiser jolheiser merged commit 61c97fd into go-gitea:main Jun 11, 2024
26 checks passed
@jolheiser jolheiser deleted the update-nix-flake branch June 11, 2024 13:47
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 11, 2024
@techknowlogick
Copy link
Member

Why add gofmpt? I thought we run it similarly to golangci-lint

@jolheiser
Copy link
Member

jolheiser commented Jun 11, 2024

Why add gofmpt? I thought we run it similarly to golangci-lint

Hm, true. This does have the benefit of having it in path for IDEs, though (assuming it's started from the nix shell or integrates with it, I guess). I'm fine with it either way personally, I think

@6543
Copy link
Member Author

6543 commented Jun 11, 2024

because then the tooling does not need install it and i can easy invoke it to format my code

@silverwind
Copy link
Member

But can you lock down its version that way? New versions might introduce formatting differences.

@6543
Copy link
Member Author

6543 commented Jun 11, 2024

well it should not but in this case we probably do want a version bumb anyway ...

I would propose to let it stay untill we do notice a problem - and as i now actively use it more or less every day I would hit that fast

@silverwind
Copy link
Member

I guess it'll be fine but if there is a way to version-lock at least some of these dependencies in this file to a certain version range, that'd be great.

@6543
Copy link
Member Author

6543 commented Jun 12, 2024

it already is via the flake.lock

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 12, 2024
* giteaofficial/main:
  Fix go-gitea#31185 try fix lfs download from bitbucket failed (go-gitea#31201)
  Enable `unparam` linter (go-gitea#31277)
  Make template `Iif` exactly match `if` (go-gitea#31322)
  update nix flake and add gofumpt (go-gitea#31320)
  code optimization (go-gitea#31315)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants