-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(library): update Duration() return values #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
==========================================
+ Coverage 97.05% 97.06% +0.01%
==========================================
Files 53 53
Lines 5772 5794 +22
==========================================
+ Hits 5602 5624 +22
Misses 125 125
Partials 45 45
|
dtanner
approved these changes
Jan 18, 2022
ecrupper
approved these changes
Jan 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
JordanSussman
approved these changes
Jan 20, 2022
This was referenced Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off feedback from #222 (comment)
This updates the value returned from
Duration()
for resources in thegithub.com/go-vela/types/library
package.The following resources have this function:
Previously, we were returning
0s
if thestarted
orfinished
timestamps weren't set for the resource.Now, If a resource doesn't have a
started
timestamp, then an indeterminate value of...
is returned.Otherwise, if a resource doesn't have a
finished
timestamp, then the time since thestarted
timestamp is returned.Otherwise, we return the
finished
timestamp subtracted by thestarted
timestamp.