Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use resource library.Duration() functions #8

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

jbrockopp
Copy link
Contributor

Based off of go-vela/types#222 and go-vela/types#227

Similar to go-vela/cli#333

This change uses the <resource>.Duration() functions from the github.com/go-vela/types/library package:

Also included in this change is the removal of the duration() helper functions for each resource.

@jbrockopp jbrockopp added the enhancement Indicates an improvement to a feature label Feb 20, 2022
@jbrockopp jbrockopp self-assigned this Feb 20, 2022
@jbrockopp jbrockopp requested a review from a team as a code owner February 20, 2022 23:16
cmd/vela-build-summary/service.go Outdated Show resolved Hide resolved
cmd/vela-build-summary/step.go Outdated Show resolved Hide resolved
@jbrockopp jbrockopp merged commit fc01232 into main Feb 24, 2022
@jbrockopp jbrockopp deleted the refactor/duration branch February 24, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants