Add more stuff/options to build #23
Conversation
Ughuuu
force-pushed
the
add-more-stuff/options-to-build
branch
from
ca3a6c0
to
6dd6a2b
Compare
|
Updated the commit history also. |
|
Before merging this will need to have secrets put in, otherwise actions will fail |
|
Also if this is accepted, will need to update the README.md with new instructions on how to reuse the build |
|
Ok, update on this. Tested the sign and it works, here: https://github.com/V-Sekai/godot-whisper/actions/runs/8007668184 |
There was a problem hiding this comment.
First of all thank you very much for this Pull Request! I finally had enough time to go through all the changes you made and I made some nitpicks in terms of grammar, the copyright notice and have some questions. Also it would be great if you could rebase all commits into one.
This looks already fantastic though :)
|
Thanks, wish it could be merged in this at some point. |
|
If you want linting also on the repo, there can be another pr that applies lint, and then i can uncomment the lines for linting. Its not that important anyway, the important parts are reusing builds flows and the signing action. |
fix issue update Update action.yml lint Update action.yml Update action.yml Update build.yml Update build.yml Update action.yml Update action.yml update with only 1 action Revert "try at root lvl" This reverts commit 0c46c0a. try at root lvl check to see if works with 4.2 upd update gdextension location to root upd upd Update action.yml Update action.yml Update action.yml Update action.yml Update action.yml upd Update action.yml Update build.yml Update build.yml upd upd fix update with matrixes upd upd upd Update builds.yml Update build-gdextension.yml Update builds.yml rename Update action.yml Remove thirdparty.txt Update action.yml Update action.yml Update action.yml Update action.yml Update README.md Update README.md Update action.yml Add build so that it can be reused. fix issue update Update action.yml lint Update action.yml Update action.yml Update build.yml Update build.yml Update action.yml Update action.yml update with only 1 action Revert "try at root lvl" This reverts commit 0c46c0a. try at root lvl check to see if works with 4.2 upd update gdextension location to root upd upd Update action.yml Update action.yml Update action.yml Update action.yml Update action.yml upd Update action.yml Update build.yml Update build.yml upd upd fix update with matrixes upd upd upd Update builds.yml Update build-gdextension.yml Update builds.yml rename update thirdparty Update action.yml Update action.yml update readme. Update builds.yml Update builds.yml upd binary name Update action.yml upd Update Info.plist remove - upd update readme upd add thirdparty. Update info about where the script comes from. Update action.yml Update builds.yml update upd Update action.yml update readme Update action.yml update Update README.md Update README.md Update README.md Update README.md Update README.md Update README.md Update action.yml Update action.yml try debug symbols Update action.yml update Update action.yml Update action.yml Update action.yml Update action.yml use macos 14.3. See if anything changes Update action.yml Update README.md Update action.yml Update action.yml Update action.yml try sudo in sh Update action.yml Update action.yml Update action.yml Update action.yml Update action.yml Update action.yml try to staple too? Update action.yml Update action.yml Update action.yml Update action.yml Update action.yml update readme. Update builds.yml Update builds.yml upd binary name Update action.yml upd Update Info.plist remove - upd update readme upd add thirdparty. Update info about where the script comes from. Update action.yml Update builds.yml update upd Update action.yml update readme Update action.yml update Co-Authored-By: Patrick Exner (FlameLizard) <[email protected]>
Ughuuu
force-pushed
the
add-more-stuff/options-to-build
branch
from
783fe06
to
8f3f206
Compare
|
Thanks for this PR and your patience with it 👍🏻 |
|
Thank you also! No worries about time, wasnt blocked by this or anything. Now i can change all places i reuse this to use this action instead of fork path. Hope the sign action will help also others, as its quite difficult to sign. |
Added an action that can build everything and that can be called from outside. Added info on how to use from readme. Added a sign action.