Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCons] Enable WASM_BIGINT in web builds #1603

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Faless
Copy link
Contributor

@Faless Faless commented Sep 23, 2024

Required since Godot 4.3, which is also the first Godot version with wide WASM gdnative support (previous versions were Chrome-only, and very brittle).

Closes #1566 (superseded).
Fixes #1553
Fixes godotengine/godot#96492

Required since Godot 4.3, which is also the first Godot version with
wide WASM gdnative support (previous versions were Chrome-only, and very
brittle).
@Faless Faless added bug This has been identified as a bug platform:web topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.3 labels Sep 23, 2024
@Faless Faless requested a review from a team as a code owner September 23, 2024 11:32
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsnopek dsnopek merged commit 64221fa into godotengine:master Sep 23, 2024
12 checks passed
@Faless Faless deleted the build/fix_wasm_bigint branch September 24, 2024 06:53
@fire
Copy link
Member

fire commented Oct 5, 2024

What's the process for cherrypicking this to 4.3 godot-cpp?

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 5, 2024

Once enough merged PRs accrue, I make a cherry-picking PR. At present, though, I'm planning to make the next set of cherry-picking PRs as soon as PR #1590 is merged, because it fixes a regression in the last batch of cherry-picks.

@dsnopek
Copy link
Collaborator

dsnopek commented Oct 28, 2024

Cherry-picked for 4.3 in PR #1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug platform:web topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
3 participants