Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Inverse Kinematics Godot 4 Conversion (Partial) #1036

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

chrisl8
Copy link
Contributor

@chrisl8 chrisl8 commented Apr 5, 2024

This is an initial attempt to convert the 3D Inverse Kinematics demo, related to updating all Demos to Godot 4 Issue #697

The project doesn't entirely work yet, but it runs. I am still working on making it work fully, but at least it starts now instead of crashing and you can cycle through the scenes and read all of the text.

I'll keep updating this when I make more parts work. I leave it up to you if you want to merge it now or wait until I have made it more functional.

I hit some of the files with my code formatter, if white-space updates are not wanted I can remove those.

I hit some of the files with my formatter, if whitespace updates are not wanted I can remove those.
The project doesn't entirely work yet, but it runs. I am still working on making it work properly fully, but at least it starts now instead of crashing.
@Calinou Calinou added the update label Apr 8, 2024
@chrisl8
Copy link
Contributor Author

chrisl8 commented Apr 11, 2024

As I wrestled with this, somebody told me that Skeleton3D is going away, because it doesn't work. Is that true? It would explain why I'm struggling with it so much.

@GeorgeS2019
Copy link

@chrisl8

Now that we have Godot4.3 beta with feature freeze, it is time to implement this demo correctly

@GeorgeS2019
Copy link

Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though this is incomplete, I'm going to merge this anyway, and further PRs can port this more. Thanks for getting this started!

@aaronfranke aaronfranke merged commit 7e2a55a into godotengine:master Aug 27, 2024
1 check passed
@GeorgeS2019
Copy link

GeorgeS2019 commented Aug 27, 2024

@aaronfranke

It needs to stress that this partial demo is not up to date with the latest 4.3 skeletonModifier.

there is now a project in c# using the latest skeleton3Dmodifier for IK

@Fripe070
https://github.com/Fripe070/Godot-Inverse-Kinematics

@chrisl8
Copy link
Contributor Author

chrisl8 commented Aug 27, 2024

Thanks, and acknowledged that my work got the demo past some basic "won't even start in Godot 4" issues, but is far from a solution to the real problem.

Unfortunately my free time to work on this has evaporated. Glad I could help. I'll jump in again if I get time again, but for now I must leave what i was able to do here.

@GeorgeS2019
Copy link

@Calinou

The demo is not complete and there is no check if it is consistent with the latest implementation of Animation concept introduced in Godot 4.3 and 4.4:

There needs to clearly state that this demo is not working to avoid others wasting time on 3D IK for Godot4

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants