Add a 3D settings demo (Graphical settings) for 4.0-dev #713
Conversation
|
Because this has to do with graphics, I guess that this has to be "Vulkan Clustered", right? I changed the README file already, if it is not correct, please let me know! |
There was a problem hiding this comment.
Some of the sides of these buttons are being cut off.
There are other settings that we should showcase in this demo. Some are nodes such as VoxelGI and ReflectionProbe. Some are WorldEnvironment settings such as SDFGI, SSAO, SSIL (looks like you already did this for SS reflections). It would also be good to showcase texture quality. Another one would be model quality (maybe using the GLTF auto-LOD system that @fire was working on). This will likely end up needing a menu with sections and a scroll bar.
This will also need a more detailed review from @Calinou to ensure that this includes what he was hoping for with a graphics settings demo. I would also appreciate if @Calinou can give thoughts on the current state, on what you've already done so far and on my suggestions, and maybe he has some other suggestions.
3d/graphics_settings/settings.gd
Outdated
|
|
||
| func _on_ui_scale_option_button_item_selected(index: int) -> void: | ||
| # For changing the UI, we take the viewport size, which we set in the project settings. | ||
| var new_size : Vector2 |
There was a problem hiding this comment.
| var new_size : Vector2 | |
| var new_size: Vector2 |
etc. https://docs.godotengine.org/en/latest/tutorials/scripting/gdscript/gdscript_styleguide.html
|
I was able to fix the border cut-off by giving the option buttons a bit more space. At this moment there are some graphical errors because of the alpha stage of the engine I'm working on Godot 4.0 alpha-5. Thank you for your input and advice! |
|
I checked out the demo locally. The demo looks like a good starting point to me (and should already be useful to users in its current form). Feel free to merge as-is and I'll make further changes in a future pull request. |
There was a problem hiding this comment.
Overall this looks great, the code is well-documented. I did encounter some bugs but I think they're all Godot bugs, not bugs with this project. I have a suggestion for getting the viewport size from project settings, and then this can be squashed and merged. Bonus points if you squash it and rebase yourself.
Could possible fix #600. This demo has some of the basic graphical settings that game devs would want. I tried to keep it minimal because it's just a demo. I hope this is sufficient and that there are enough comments explaining everything. Everything works without any bugs or errors. Small fix Small script format fix Small fix Small fix Changed readme Update 3d/3d_settings_menu/project.godot Co-authored-by: Aaron Franke <[email protected]> Fixing many mistakes Changed folder name Deleted git files changed the default size with the project settings variant Removed some debug info Added extra features Changed the layout into sections, Added some extra settings and features. Waiting for Calinou to see what he would like to change/add. Small fixes Getting the start viewport in ready
I think I earned myself some bonus points. ^o^ |
|
Thanks! |
|
This demo crashes as soon as I start it, both on 4.0alpha6 and latest The demo can be successfully opened in the editor, but it will crash instantly on start before a single frame is even rendered. The last version that can run the demo correctly is 4.0alpha5. |
|
Just downloaded alpha 6 to test if I have the same issue, but for me everything runs fine.
But I do get errors like these: |
Could possible fix #600.
This demo has some of the basic graphical settings that game devs would want. I tried to keep it minimal because it's just a demo. I hope this is sufficient and that there are enough comments explaining everything. Everything works without any bugs or errors.