Improve the 3D graphics settings demo #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
improve-3d-graphics-settings-demo
branch
5 times, most recently
from
250d875
to
0e7dbed
Compare
Calinou
force-pushed
the
improve-3d-graphics-settings-demo
branch
2 times, most recently
from
c05b202
to
5289438
Compare
aaronfranke
reviewed
Apr 25, 2022
- New graphics settings:
- Field of view.
- Volumetric fog.
- Use Godot's built-in 3D viewport facilities instead of using a SubViewport.
- This also allows for choosing AMD FidelityFX Super Resolution
for resolution scaling, but it's not working yet due to a Godot bug.
- Nearest-neighbor scaling is no longer available. It can be
reimplemented in Godot core and then exposed in the future.
- Separate MSAA from FXAA settings, as both can be used at the same time.
- Add more quality settings for various effect settings.
- Rename sections and setting names to be more "player-oriented"
(even if this results in the actual Godot terminology not being
presented).
- Add performance hints to setting values.
- Add FPS counter and viewport resolution display
(taking the resolution scale into account).
- Add more objects to the test scene and tweak environment settings.
- ACES tonemapping is now used.
- Debanding is now enabled, as this scene requires it to avoid visible
banding.
- Make the emissive box less bright to prevent MSAA and FXAA from
being ineffective on it (due to Godot not supporting correct
HDR antialiasing).
- Remove unnecessary DirectionalLight3D, VoxelGI and ReflectionProbe.
Calinou
force-pushed
the
improve-3d-graphics-settings-demo
branch
from
5289438
to
48d2ec9
Compare
aaronfranke
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #713.
There's more stuff that could be done in the future (such as adding shadow quality settings), but this is a good start already.
Preview