Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Multiple Resolutions demo for Godot 4.0 #733

Merged
merged 1 commit into from
May 7, 2022
Merged

Update Multiple Resolutions demo for Godot 4.0 #733

merged 1 commit into from
May 7, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 2, 2022 •
edited
Loading

See #697.

Preview

image

Older revision

multiple_resolutions

@Calinou Calinou mentioned this pull request May 2, 2022
Merged
@Calinou Calinou added the update label May 2, 2022
@Calinou Calinou force-pushed the multiple-resolutions-update-to-4.0 branch from 1e4e1f7 to 6b08e79 Compare May 2, 2022 17:27
@Calinou
Copy link
Member Author

Calinou commented May 2, 2022 •
edited
Loading

I made some changes:

  • Changed rendering backend to Vulkan Mobile.
  • Enabled MSDF for the default font to allow for faster resizing of the window. The font no longer needs to be re-rasterized when its size changes.
    • Rasterizing fonts is a fair bit slower in master compared to 3.x. We should profile this and check where it can be optimized.
  • Removed unused font file (since the default project font is used now).

@aaronfranke aaronfranke added this to the 4.0 milestone May 7, 2022
@aaronfranke
Copy link
Member

aaronfranke commented May 7, 2022 •
edited
Loading

The side lables overlap with the text. Maybe we should remove the side labels from this demo, or add a toggle, or a second page, or move them to the corners, or something?

Screenshot from 2022-05-07 17-10-53

@Calinou Calinou force-pushed the multiple-resolutions-update-to-4.0 branch from 6b08e79 to e591cee Compare May 7, 2022 23:35
@Calinou
Copy link
Member Author

Calinou commented May 7, 2022

@aaronfranke Done, I moved the labels to the top-left and bottom-left corners.

@aaronfranke aaronfranke merged commit 92e24ce into godotengine:4.0-dev May 7, 2022
@Calinou Calinou deleted the multiple-resolutions-update-to-4.0 branch May 7, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
update
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Calinou @aaronfranke