Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gd paint from godot 3 #969

Closed
wants to merge 3 commits into from
Closed

gd paint from godot 3 #969

wants to merge 3 commits into from

Conversation

Ghofar05
Copy link

hello, this is converted project demo of gd paint from godot 3 to godot 4. i've make sure there no bug. thankyou

@@ -0,0 +1,253 @@
extends Control

# A constant for whether or not we're needing to undo a shape.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# A constant for whether or not we're needing to undo a shape.
# A constant for whether or not we're needing to undo a shape.

@@ -0,0 +1,113 @@
extends Panel

@onready var brush_settings = $BrushSettings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@onready var brush_settings = $BrushSettings
@onready var brush_settings = $BrushSettings

brush_settings.modulate = Color(1, 1, 1, 0.5)
tool_name = "Circle shape"

# If a brush shape button is pressed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# If a brush shape button is pressed
# If a brush shape button is pressed.

Per the comment style.

paint_control.brush_shape = paint_control.BrushShapes.CIRCLE
shape_name = "Circle";

# If a opperation button is pressed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# If a opperation button is pressed
# If a opperation button is pressed.

}

# The top-left position of the canvas.
var TL_node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var TL_node
var tl_node

snake_case

Comment on lines +168 to +169
var TL_pos = Vector2()
var BR_pos = Vector2()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var TL_pos = Vector2()
var BR_pos = Vector2()
var tl_pos = Vector2()
var br_pos = Vector2()

@Calinou
Copy link
Member

Calinou commented Sep 25, 2023

GDPaint was already updated for Godot 4 here, and is fully functional: https://github.com/godotengine/godot-demo-projects/tree/master/gui/gd_paint
I tested it in 4.2.dev5 last week.

@aaronfranke
Copy link
Member

Calinou is correct, this demo has already been ported and goes in the GUI folder, not the 2D folder, as of #742.

@Ghofar05
Copy link
Author

my bad, sorry. i was think this demo have not ported yet because i couldn't find this demo in the godot 4 editor asset library project

@Calinou
Copy link
Member

Calinou commented Sep 26, 2023

my bad, sorry. i was think this demo have not ported yet because i couldn't find this demo in the godot 4 editor asset library project

See #920.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants