Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compiling for Android JDK version specification #5312

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

madmiraal
Copy link
Contributor

Currently, the Compiling for Android documentation specifies JDK version 8; stating that JDK version 9 or later are not supported. However, this was based on Gradle version 2, which, indeed, did not support JDK version 9 or later. The current version of Gradle used is 6.7.1, which supports JDK 15[1].

JDK 11 is required to upgrade the Android Gradle plug-in to Gradle 7.0. The current OpenJDK and (previous) Oracle LTS JDK version is 11. Therefore, this PR updates the documentation to specify using JDK version 11.

BTW: Oracle has recently (September 2021) released a new LTS: JDK 17[2]) but both OpenJDK and Gradle need to catchup before we can specify this.

[1] https://docs.gradle.org/current/userguide/compatibility.html
[2] https://en.wikipedia.org/wiki/Java_version_history#Java_17

@mhilbrunner mhilbrunner added the bug label Oct 9, 2021
@mhilbrunner mhilbrunner merged commit d0b2540 into godotengine:master Oct 9, 2021
@mhilbrunner
Copy link
Member

Thanks!

@skyace65
Copy link
Contributor

skyace65 commented Oct 9, 2021

Does this also mean newer versions of OpenJDK can be used for exporting projects to android? Currently we say to use OpenJDK 8.

@madmiraal madmiraal deleted the update-jdk-version branch October 10, 2021 08:01
@madmiraal
Copy link
Contributor Author

Does this also mean newer versions of OpenJDK can be used for exporting projects to android? Currently we say to use OpenJDK 8.

Yes. That needs to be updated too. Thanks for pointing it out.

@Calinou
Copy link
Member

Calinou commented Oct 15, 2021

Cherry-picked to the 3.4, 3.3 and stable branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants