-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency section to gdextension file docs #9569
Add dependency section to gdextension file docs #9569
Conversation
Merged! Feedback by @dsnopek still appreciated, saw the review request too late, oops. |
@mhilbrunner No worries. I can patch it up very quickly if there is any feedback 👍🏻 |
This looks good to me! The only note that I would add, is that the most common way to use
On MacOS, I think using the path In any case, I think we should try to include some paths that are actually used in the wild, in order to help folks figure out how to use this. |
Hey, @paddy-exe and @dsnopek! Am I missing something about these dependencies? When I looked into Godot codebase, I only saw If this is only implemented on Android, then this must be reflected in the documentation in two ways: an explicit note and all examples for other platforms must be removed. Or am I missing some indirect use? PS. Well, export plugins system also extracts this information for its own use via PPS. Or is that it, the export part is what handles most other platforms and that's sufficient? Sorry if this is a dumb question. |
@YuriSizov I haven't looked at the implementation for specific platforms but I assure you I have tested it both on Linux and even more extensively on Mac to make sure it works. I am not aware if there are more specific requirements for loading on mobile platforms though. |
Cherry-picked to 4.2 in #9648. |
Continuation of #9383
Fixes #9462
also removes a double word