Support for #includes in built-in GL shaders.

[SaracenOne]

I've added support to the Python script responsible for scanning and exposing the data of the native GLSL into headers to be able to use the #include directive. Since this is a precompiler routine, there are no concerns over driver compatibility, and these additions should also provide protection from recursion or double inclusion. The reason I wanted to add this is thought that if the builtin shaders are going to grow in complexity in the future, it may be an idea to refactor into sets of more managable submodules. Currently, the ubershaders used are quite difficult to follow since composed almost entirely of #ifdefs. In future, I would also like to add similar functionality to user shaders too

[reduz]

oh wow this is really useful, will merge as soon as I can

On Sun, May 1, 2016 at 9:51 AM, SaracenOne [email protected] wrote:

I've added support to the Python script responsible for scanning and
exposing the data of the native GLSL to be able to use the #include
directive. Since this is a precompiler routine, there are no concerns over
driver compatibility, and these additions should also provide protection
from recursion or double inclusion. The reason I wanted to add this is
thought that if the builtin shaders are going to grow in complexity in the
future, it may be an idea to refactor into sets of more managable
submodules. Currently, the ubershaders used are quite difficult to follow
since composed almost entirely of #ifdefs. In future, I would also like to

add similar functionality to user shaders too

You can view, comment on, or merge this pull request online at:

#4505
Commit Summary

• Support for #includes in built-in GL shaders.

File Changes

• M methods.py
  https://github.com/godotengine/godot/pull/4505/files#diff-0 (138)

Patch Links:

• https://github.com/godotengine/godot/pull/4505.patch
• https://github.com/godotengine/godot/pull/4505.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#4505

[SaracenOne]

Hold on, I think there's a problem with this commit I've just discovered. I'm fixing it right now.

[akien-mga]

Too late ;) But you can make a second PR, no problem.