Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area2D doesn't update its overlapping areas when monitorable changes in the areas it's overlapping #23484

Closed
Tracked by #45334
MightyPrinny opened this issue Nov 3, 2018 · 3 comments · Fixed by #41698

Comments

@MightyPrinny
Copy link
Contributor

MightyPrinny commented Nov 3, 2018

Godot version:
3.1 alpha2 mono x64

Issue description:
An area that is monitoring will never detect that an area exited if the other area leaves while it is not monitorable and will remain in the list returned by get_overlapping_areas. Similarly an area that is monitoring will never detect that an area entered if the other area enters while it is not monitorable and switches to monitorable while it's inside.
*Steps to reproduce:
This can easily be reproduced with a static area switches between monitorable and not monitorable and another area that checks if get_overlapping_areas is empty

Minimal reproduction project
Area2DProblem.zip

@akien-mga
Copy link
Member

akien-mga commented Nov 5, 2018

Might be a duplicate of #17330, can you confirm that issues happen only when toggling monitorable off, and toggling it on doesn't restore proper behaviour?

@MightyPrinny
Copy link
Contributor Author

I think it could be the same bug just that the other issue doesn't mention that the list returned by get_overlapping_areas keeps the areas that are not monitorable even if the areas are not overlapping. I wanted to add more details but the way the areas go back to work correctly seems inconsistent.

@akien-mga
Copy link
Member

Just a quick update since this issue hasn't got any comment in a while: there are currently two open PRs that aim at solve it (#32299 and #41698), but both are pending review from @reduz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants