--convert-3to4 doesn't convert shaders

[TokisanGames]

Godot version

5c6744a

System information

Win 10/64 NVIDIA GeForce GTX 1060/PCIe/SSE2

Issue description

According to my incomplete conversion log found in issue #63672, all my shaders in assets/shaders were converted. However the work is far from complete.

• There are new .gdshader files, but all the old .shader files are still there and weren't deleted or renamed.

• The new shaders have render_mode async_visible, which GD4 doesn't support and gives an error.

• In fact, the shaders were hardly touched at all. The only difference I see is NORMAL_MAP. There are so many more issues.

These are all of the necessary conversions I have identified for my shaders. I'm not sure about backlight. It appears to be a functional replacement, but it is a poor quality replacement. I haven't decided if it needs an issue filed yet.

			$line =~ s/async_visible,?//g;
			$line =~ s/depth_draw_alpha_prepass/depth_draw_opaque/g;
			$line =~ s/hint_color|hint_albedo/source_color/g;
			$line =~ s/hint_white/hint_default_white/g;
			$line =~ s/hint_black_albedo|hint_black/hint_default_black/g;
			$line =~ s/hint_aniso/hint_anisotropy/g;
			$line =~ s/NORMALMAP/NORMAL_MAP/g;
			$line =~ s/INV_CAMERA_MATRIX/VIEW_MATRIX/g;
			$line =~ s/CAMERA_MATRIX/INV_VIEW_MATRIX/g;
			$line =~ s/WORLD_MATRIX/MODEL_MATRIX/g;
			$line =~ s/TRANSMISSION/BACKLIGHT/g;
			$line =~ s/ALPHA_SCISSOR/ALPHA_SCISSOR_THRESHOLD/g;

@qarmin

[qarmin]

Problem with getting automatically list of all available shader values is reason why so much things are not renamed in shaders.
Feel free to open PR with shader renames so other contributors could look at this renames(I don't use shaders in code, so I can't really check if this renames are valid)

Place where such renames could be added

godot/editor/project_converter_3_to_4.cpp

Lines 1223 to 1229 in ea4b8de

	static const char *shaders_renames[][2] = {
	{ "ALPHA_SCISSOR", "ALPHA_SCISSOR_THRESHOLD" },
	{ "NORMALMAP", "NORMAL_MAP" },
	{ "NORMALMAP_DEPTH", "NORMAL_MAP_DEPTH" },
	{ "TRANSMISSION", "SSS_TRANSMITTANCE_COLOR" },
	{ nullptr, nullptr },
	};

Problem with not removing shader fle should be fixed when merging latest PR with bugfix

[XaurDesu]

would it be possible to replicate this bug on a different Nvidia SKU? for reference, i currently have a 1650 mobile and a gtx 960. Is there any way i can replicate this problem?

[TokisanGames]

Has nothing to do with the hardware, so yes. And it's not a bug, it just wasn't implemented at the time of creation.

If you have your own project, use the search and replace lines to manually convert it.

If you're making an engine PR, follow the direction in the 1st and 2nd posts to rename files and edit scripts based on the identified patterns.

[XaurDesu]

Alright, i'll take a look into this.

[guilhermevfa]

Hi! I was searching discrepancies between the Godot 3.5 and Godot 4.1 shader docs in hopes of contributing to fix this issue. Basically I found one wrong existing coversion (depth_draw_alpha_prepass).
There are other discrepancies of things that Godot 4 doesn't support (like render_mode async_visible or LIGHT_VEC), but I'm not sure what could be done about that.
I'm trying to find other places to compare documentation and figure out what might be missing. Any suggestions for such resources would be really helpful. If you don't have any, I'll probably just submit my pull request for review.