Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various converter enhancements and bugfixes #63887

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

qarmin
Copy link
Contributor

@qarmin qarmin commented Aug 3, 2022

Fixes #62832
Fixes #63291
Fixes #63292
Fixes #63292

Fixed error message about not checking files greater than 500KB(proper message should be that files greater than 4MB are not checked to avoid freezes) #63672

From #63673 I fixed problem with not removing old .shader file - the problem was caused by attempting to remove not-existent file, but also by missing error message in case of trying to remove such file, so I added additional error message to dir_access.h

This PR removes a lot of duplicated code and also add regex cache.

I tried to add const object of type RegExContainer to main converter class, to be able to avoid to pass object of this type to different functions, but I failed to do this due various C++ errors like "Field has incomplete type" or related to RegEx(this probably was my fault).

Supersedes #63299 - not contains patches with RayQueryParameters because looks that this will change in future

Tested with Jetpaca, and after small fixes it works partially

@qarmin qarmin requested a review from a team as a code owner August 3, 2022 19:54
@qarmin qarmin marked this pull request as draft August 3, 2022 20:16
@qarmin qarmin marked this pull request as ready for review August 3, 2022 20:29
@rburing
Copy link
Member

rburing commented Aug 4, 2022

FYI #61918 was merged and allows easier conversion of intersect_ray calls by allowing PhysicsRayQueryParameters to be created with a single static function call.

@akien-mga akien-mga merged commit 10f9f20 into godotengine:master Aug 5, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants