Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0]Pressing Enter to ensure the changging of Inspector property will suddenly change the interface focus from Inspector to Node #69160

Closed
snougo opened this issue Nov 25, 2022 · 8 comments · Fixed by #69234 or #72378

Comments

@snougo
Copy link

snougo commented Nov 25, 2022

Godot version

4.0 beta4/beta5/beta6

System information

macOS 11.7.1 Intel-iris-GPU Forward+ and Mobile

Issue description

when pressing Enter to ensure the changging of Inspector will suddenly change the interface focus from Inspector to Node, it's really annoying.

Screen.Recording.2022-11-25.at.4.34.04.PM.mov

Steps to reproduce

pick up a node
change inspector property
press enter

Minimal reproduction project

Uploading Godot4Beta5Mobile.zip…

@snougo snougo changed the title [4.0]Pressing Enter to ensure the changging of Inspector will suddenly change the interface focus from Inspector to Node [4.0]Pressing Enter to ensure the changging of Inspector property will suddenly change the interface focus from Inspector to Node Nov 25, 2022
@Chaosus Chaosus added this to the 4.0 milestone Nov 26, 2022
@Sauermann
Copy link
Contributor

Bisecting this bug shows that it got introduced in #67397.

@PabloNeirotti
Copy link

PabloNeirotti commented Nov 29, 2022

Also have this issue on macOS Ventura 13.0.1.

I believe I didn't experience this on beta2 but now on beta6 I do.

A temporary workaround is to build the muscle memory of hitting return twice to confirm a change.

@snougo
Copy link
Author

snougo commented Dec 10, 2022

Not be fixed in beta8

@akien-mga akien-mga reopened this Dec 10, 2022
@Sauermann
Copy link
Contributor

Sauermann commented Dec 10, 2022

Thanks for the feedback. As mentioned in #69234 (comment), I was not certain, if that PR would solve this issue on macOS.

@snougo
Copy link
Author

snougo commented Dec 10, 2022

Thanks for the feedback. As mentioned in #69234 (comment), I was not certain, if that PR would solve this issue on macOS.

Let me create a new empty project to see if it has been fixed in beta8

@snougo
Copy link
Author

snougo commented Dec 10, 2022

I created a new empty project in beta 8, but the issue is still there, not be fixed.

@sfaletti
Copy link

Not sure if this helps, but I have the same issue on MacOS with an M1 Max processor and have noticed weird behavior when tabbing through property fields. I'm using beta8.

If I click on a field right after I've opened or created a scene, it will highlight as normal and I can edit it. Pressing return focuses on the Node per @snougo's comment. Pressing tab initially does nothing, but shift+tab will focus on the previous field in the list. After I've gone back using shift+tab I can go forward using tab but only 1 field, then tab has no effect again. If I back up from this point with shift+tab I can go forward again. Once I've done this back-and-forth dance with tab through the first section of the inspector panel it seems to work normally.

This video might explain it better. It shows me tabbing through the properties of a new Node2D.

Godot-v4-beta8_MacOS-M1Max_PropertyFocus.mp4

@lostminds
Copy link

lostminds commented Jan 4, 2023

I'm getting this in 4.0.beta10 as well on macOS 13.0.1.

It's especially annoying combined with the issue that command-key shortcuts aren't properly consumed (see #63888 #68122) in field editors. So for example the very common key sequence of hitting enter to enter a node inspector field value and then command-s to save results in the node name being focused as described above and then the node renamed "s" due to the command-s key event both saving the project and entering an s in the field replacing the old node name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment