Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focus after pressing Enter in EditorSpinSlider #69234

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Sauermann
Copy link
Contributor

@Sauermann Sauermann commented Nov 26, 2022

With the change from Popup to Controls for the Input-Node in #67397, it becomes necessary to adjust focus after hiding the Input-Node back to the initial Control.

resolve #69160

With the change from Popup to Controls for the Input-Node, it becomes
necessary to adjust focus after hiding the Input-Node to the initial
Control.
@Sauermann
Copy link
Contributor Author

According to the video in #69160 the bug manifests a bit different in MacOS and in Linux.
On linuxbsd it doesn't happen, that an input field is opened for editing the node-name in the SceneTree.
On linuxbsd the edited property loses its focus, after the Enter key.

It could be, that this PR solves the problem only for linuxbsd.

@akien-mga akien-mga merged commit 68dc56f into godotengine:master Dec 6, 2022
@Sauermann Sauermann deleted the fix-enter-focus branch December 6, 2022 12:13
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants