Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected input/focus issues everywhere #70673

Open
essial opened this issue Dec 28, 2022 · 9 comments
Open

Unexpected input/focus issues everywhere #70673

essial opened this issue Dec 28, 2022 · 9 comments

Comments

@essial
Copy link

essial commented Dec 28, 2022

Godot version

4.0 custom build (b6e0603), also on official beta 10

System information

MacOS (M1 Air 2020)

Issue description

Although I've "gotten used" to the strangeness, there are a number of issue related to focus and navigation throughout the IDE. At least on MacOS (ARM64).

Steps to reproduce

The CMD+B action doesn't seem to work in the official beta 4.0 release to launch the project, though it does seem to work in the latest dev commit. However, this is only true if I select a selectable section of the IDE that is not the code editor. If I'm in the code editor, CMD+B does not work. CMD+R (launch scene) DOES seem to work with the code editor in focus.

CMD+Shift+O will launch the quick open scene dialog if anything BUT the code editor is selected. If the code editor is selected, pressing that combination enters block selection mode with the cell immediately above the cursor selected (two cursor selection).

Pressing "enter" on a popup dialog will accept the dialog, but will also put whatever node was previously selected in FileSystem or Scene into edit mode. I get that MacOS defaults to renaming with Enter, but this is honestly a really difficult thing to get right, especially when a lot of other actions use Enter. In Finder, Enter is only ever going to rename a file. Here, enter does an actual action as well. I think renaming should be similar to what I'm assuming it is in windows where you right click to rename, or click, wait click like in other apps.

Sometimes pressing CMD+R, CMD+B, or CMD+S will actually begin renaming a node in the scene tree - though I'm unable to reproduce this reliably.. it just randomly happens (quite often, unfortunately).

Sometimes the editor seems to not be able to obtain focus when clicking inside of the editor window. This is typically fixed by clicking the desktop then clicking back on the editor. I've seen this in other apps however and may be a MacOS issue.

Minimal reproduction project

No project is necessary as these are general UI issues that affect any and all projects.

@Calinou
Copy link
Member

Calinou commented Dec 29, 2022

Related to #66678 and #68352 (possible duplicate).

@cbscribe
Copy link
Contributor

Confirmed. Tab also doesn't advance to the next focus target as it does on Windows.

@firebelley
Copy link

Just adding something I have noticed as well: in a 2D scene, using the arrow keys to move a Node2D by 1 pixel increments will instead focus some of the toolbar buttons after a couple of keypresses.

@strangebirds
Copy link

I think this is a related focus issue, but on 4.0.b13 (and earlier, back to 4.0.b7 where I first noticed it). If you Add a Node and double-click to select it, the script underneath it in the editor begins a selection (highlighting the script text) as though shift-click had been used.

MacOS 12.6.2
Godot 4.0.b7-b13 (GDScript)

@lostminds
Copy link

Regarding the renaming of nodes issue, this is probably a duplicate of this issue: #69160 and #71605 (basically pressing enter in an inspector panel field will shift focus and select the selected node name, so you next key press for running or saving then renames the node...). While they're still open they're listed as fixed by a pull request #69234 that has been merged. But the issue is still present in 4.0b13

@Sauermann
Copy link
Contributor

While they're still open they're listed as fixed by a pull request #69234 that has been merged

#69234 fixed a related problematic behavior on linux, but not for macOS.

@lostminds
Copy link

The issues with some GUI events not being consumed have been fixed #72378 and I've not seen them in a while. Could not reproduce the issues with those in 4.0.3 now when I tried it. @essial are you still seeing these issues?

@jotson
Copy link
Contributor

jotson commented Jun 29, 2023

Using Ubuntu 22.04 / Nvidia 1060 / 4.1rc1

Sometimes when I open the Quick Open dialog (Ctrl+Shift+O) the Search box has focus but there is no input caret visible and I can't type in it.

This bug is intermittent and I don't have a reliable reproduction process, unfortunately. I thought originally it was due to searching for something that doesn't exist (no Matches) and hitting cancel. But that only causes the problem sometimes. Also, sometimes selecting a match and hitting cancel will cause it to happen. Sometimes just escaping (Esc) out of the dialog will make it happen.

A weird thing that happens is if the Godot Editor loses focus while the dialog is open, the cursor will appear when the window regains focus again.

Screenshot from 2023-06-29 07-44-25

@hsandt
Copy link
Contributor

hsandt commented Jan 16, 2024

Linux Ubuntu 22.04 with Unity (not the official from Ubuntu Unity but an old one from 16.04, when Unity desktop was default - which possibly causes extra issues)

Quick Open Scene/Script (Ctrl+Shift+O, Ctrl+Alt+O) work fine on my side.

On the contrary, the Open Scene popup (Ctrl+O) only takes focus for an instant and then immediately loses it (at 100%), forcing me to click on the window or press Alt+Tab to refocus.

There may be many different issues in this big issue, if devs can identify different causes for the different OS and popups then we can create one issue per variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants