Several build options produce non-working editors

[stefano-elysium]

Godot version

5dccc94

System information

Xubuntu

Issue description

Command: scons platform=linux

Compiling the editor with module_svg_enabled = "no", causes a crash on startup.

Compiling the editor with module_text_server_adv_enabled = "no" breaks the texts and it looks like this:

(Message in console: WARNING: Some locales are not properly supported by selected Text Server and are disabled. )

Compiling the editor with the module_text_server_adv_enabled, but with option module_freetype_enabled = "no" causes compilation failure, messages [ 46%] In file included from modules/text_server_adv/thorvg_svg_in_ot.cpp:58: modules/text_server_adv/thorvg_svg_in_ot.h:55:10: fatal error: freetype/freetype.h: No such file or directory 55 | #include <freetype/freetype.h> | ^~~~~~~~~~~~~~~~~~~~~ compilation terminated. [ 67%] In file included from modules/text_server_adv/text_server_adv.cpp:76: modules/text_server_adv/thorvg_svg_in_ot.h:55: fatal error: freetype/freetype.h: No such file or directory 55 | #include <freetype/freetype.h> | compilation terminated.

Steps to reproduce

As above.

Minimal reproduction project

N/A

[AThousandShips]

The SVG crash will be fixed by #74551 it looks like

[AThousandShips]

The SVG without freetype is a bug though, the module check isn't checking for freetype even though it is required for that to work, will look at a fix

[AThousandShips]

See #74556

[YuriSizov]

The cases reported here are addressed by #74551 and #74556. Note that disabling those modules will never produce a completely working editor, because it is not building without those modules in mind. The best we can guarantee is that it doesn't crashes.

[stefano-elysium]

@YuriSizov if it will never produce a working editor, why not prevent editor builds, like if advanced UI is disabled?

[YuriSizov]

That's a good idea!