[TextServer] Make sure Freetype is enabled for ot-svg #74556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
approved these changes
Mar 7, 2023
|
Oh didn't see it was in that too, will add it |
This comment was marked as outdated.
This comment was marked as outdated.
AThousandShips
force-pushed
the
text_adv_svg_freetype
branch
from
ed253a8
to
eb09b36
Compare
AThousandShips
force-pushed
the
text_adv_svg_freetype
branch
from
eb09b36
to
3a5d7a4
Compare
bruvzg
approved these changes
Mar 7, 2023
|
@AThousandShips Does this close #74546 completely now? (my PR for the icons was merged already) |
|
Thanks! |
|
It looks like there's still a bug without the advanced server giving no text, but think that might be a duplicate |
|
Thank you! |
It's not a bug, text server is what's loading fonts and rendering text, so if none is enabled (neither |
|
Then we can close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling Freetype but not SVG causes text_server_adv/_fb to fail to compile due to incorrect module detection, as ot-svg requires both.
Issue #74546 (this is not the only problem in that so not "fixed" necessarily)