-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Err when trying to build the editor without its required modules #74980
Err when trying to build the editor without its required modules #74980
Conversation
This check used to exist (still does in 3.x) but was removed in 951a101, possibly as an oversight. CC @Faless Makes sense to add back.
The editor should be able to run without GDScript, as long as you're not trying to run GDScript code. So if it doesn't, this should be fixed. Likewise for rendering, it should work in headless mode if no valid renderer is compiled, so this would be worth looking into separately. |
Do you want me to try and restore it as it was, without hardcoding these two specific dependencies? |
Yeah I think the old format was a bit more flexible to add more modules to the array. In theory the module dependency graph added by Fabio could be used for this too but since the editor isn't a module, it doesn't run this check. |
bf2d06e
to
a145194
Compare
Okay, made the changes. The output looks something like this now:
We still need to explicitly list the dependencies, if I understand correctly. I don't see that being done in the old version, I'm not sure it even worked? |
Thanks! |
Cherry-picked for 4.0.3. |
See #74546 (comment). I didn't add the same check for the text server being disabled, because you can extend it with a third party module instead, and I don't think we can detect that there is no text server implementation whatsoever during this validation step.