Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open filters in non-exclusive FileDialog #79052

Closed
L4Vo5 opened this issue Jul 5, 2023 · 2 comments · Fixed by #79084
Closed

Can't open filters in non-exclusive FileDialog #79052

L4Vo5 opened this issue Jul 5, 2023 · 2 comments · Fixed by #79084

Comments

@L4Vo5
Copy link
Contributor

L4Vo5 commented Jul 5, 2023

Godot version

v4.1.rc3.official [cdd2313]

System information

Godot v4.1.rc3 - Windows 10.0.19045 - Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 Threads)

Issue description

Trying to open the filters (file types) menu in a non-exclusive FileDialog makes it automatically close and brings up the following error in the console/debugger:

ERROR: Condition "!windows.has(p_window)" is true. Returning: Rect2i()
   at: window_get_popup_safe_rect (platform/windows/display_server_windows.cpp:2426)

This seems to have been broken somewhere between 4.1 beta 2 and beta 3.

Steps to reproduce

  • Create a FileDialog
  • Untick the "Exclusive" box
  • Make it visible / pop it up / etc
  • Try opening the All Files (*) menu

Minimal reproduction project

dialog_test.zip

@Sauermann
Copy link
Contributor

Sauermann commented Jul 5, 2023

For future reference, please also include the godot.project-file in the MRP. The .tscn-file is usually not enough, because it lacks project-specific information.

When testing this with embedded windows enabled, I can confirm the problem. (#78476 addresses part of this problem, but I doubt, that it is enough to solve it)
When testing this with embedded windows disabled, the FileDialog simply closes after clicking on All Files (*).

My guess is that this got introduced in #78363.

A workaround is to set the AcceptDialog option Close on Escape from On to Off.

@L4Vo5
Copy link
Contributor Author

L4Vo5 commented Jul 5, 2023

For future reference, please also include the godot.project-file in the MRP. The .tscn-file is usually not enough, because it lacks project-specific information.

Oh, I tested it on a blank project, so I didn't think that file would matter.

Thanks for the workaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants