Embedded Popups store their safe_rect in their embedder #78476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do a rebase and force-push to rerun the CI. |
Storing it in the DisplayServer didn't make sense in this case, because the embedded window is unknown to the DisplayServer.
Sauermann
force-pushed
the
fix-embedded-safe-area
branch
from
1e87271
to
a126277
Compare
6 tasks
RandomShaper
approved these changes
Jun 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing it in the DisplayServer didn't make sense in this case, because the embedded window is unknown to the DisplayServer.
Current behavior leads to problems when used within Gui-in-3D or XR.
part of #77189