Fix focusloss of non-exclusive AcceptDialog with close_on_escape
#78363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix, that a non-exclusive AcceptDialog with `close_on_escape == true` gets closed, when the parent window of the parent window receives focus. There is no need to rely on the focus of the parent visible window. Instead check if the AcceptDialog loses focus.
YeldhamDev
approved these changes
Jun 17, 2023
|
Thanks! |
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix, that a non-exclusive AcceptDialog with
close_on_escape == truegets closed, when the parent window of the parent window receives focus.There is no need to rely on the focus of the parent visible window. Instead check if the
AcceptDialogloses focus.This is also a prerequisite for #72686
Tested:
MRP: AcceptDialogFocus.zip
The AcceptDialog shoud now close, because it is non-exclusive and
close_on_escape == true.Current behavior is, that it doesn't close.
Alternative:
3. Click on the secondary window (now the AcceptDialog closes itself as expected)