Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes possible to interpret comma as decimal point in editor #13240

Merged
merged 1 commit into from
Nov 26, 2017
Merged

Makes possible to interpret comma as decimal point in editor #13240

merged 1 commit into from
Nov 26, 2017

Conversation

Krakean
Copy link
Contributor

@Krakean Krakean commented Nov 24, 2017 •
edited
Loading

Fixes issue #6028 and #6104
After some tests, looks like everything works smoothly.

This is how it looks in action: https://i.imgur.com/j8FUoBp.gifv

@akien-mga akien-mga added this to the 3.0 milestone Nov 24, 2017
akien-mga
akien-mga requested changes Nov 26, 2017
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are style issue (see Travis logs), but beyond that when discussing it with @reduz we realized that it won't work everywhere.

It would be better to implement this directly in ValueEvaluator::eval.

@Krakean Krakean force-pushed the fix_interpretcomma_as_decimalpoint branch from fe70aa6 to a410920 Compare November 26, 2017 20:11
@Krakean
Copy link
Contributor Author

Krakean commented Nov 26, 2017

@akien-mga thought about it initially, but was kinda scary to broke something up by modifying such common function.
Anyway, done, check.

@akien-mga akien-mga merged commit 03a2cf2 into godotengine:master Nov 26, 2017
@Krakean Krakean deleted the fix_interpretcomma_as_decimalpoint branch November 27, 2017 07:02
@akien-mga akien-mga mentioned this pull request Nov 29, 2017
Closed
@kondelik kondelik mentioned this pull request Dec 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga requested changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Krakean @akien-mga