Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take CSG into account for nav-mesh generation #29749

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Take CSG into account for nav-mesh generation #29749

merged 1 commit into from
Jun 13, 2019
+19 −1

Conversation

JFonS
Copy link
Contributor

@JFonS JFonS commented Jun 13, 2019

Closes #20281.

@JFonS JFonS requested a review from BastiaanOlij as a code owner June 13, 2019 11:52
@JFonS JFonS mentioned this pull request Jun 13, 2019
Closed
@akien-mga akien-mga added this to the 3.2 milestone Jun 13, 2019
akien-mga
akien-mga approved these changes Jun 13, 2019
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, provided @reduz confirms that we can add such module inter-dependencies (I don't see much reason not to, but I prefer to check).

@StraToN StraToN added bug and removed bug labels Jun 13, 2019
@akien-mga
Copy link
Member

Confirmed ok by @reduz.

@akien-mga akien-mga merged commit b2b06dd into godotengine:master Jun 13, 2019
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Doesn't cherrypick cleanly on current 3.1 branch, skipping for now.

@JFonS JFonS deleted the add_csg_navmesh branch May 4, 2021 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@BastiaanOlij BastiaanOlij Awaiting requested review from BastiaanOlij

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

CSG shapes are ignored for navmesh
3 participants
@JFonS @akien-mga @StraToN