Added 'Replace in files' functionality to text editors #36044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamsComeTrue
force-pushed
the
fix-replace-all-shortcut
branch
from
412763b
to
25821cc
Compare
Paulb23
requested changes
Feb 13, 2020
dreamsComeTrue
force-pushed
the
fix-replace-all-shortcut
branch
from
25821cc
to
4c80bea
Compare
dreamsComeTrue
commented
Feb 13, 2020
| @@ -886,7 +951,7 @@ void FindInFilesPanel::apply_replaces_in_file(String fpath, const Vector<Result> | |||
| } | |||
|
|
|||
| String FindInFilesPanel::get_replace_text() { | |||
| return _replace_line_edit->get_text().strip_edges(); | |||
There was a problem hiding this comment.
That bit was there since forever - now, replacement text is fully set (even with border spaces)
|
Thanks! |
|
Hoorayy! Thank you, sir :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses same 'find_in_files' dialog as for regular search in files.
Sets
Ctrl + Shift + Ras shortcut for bringing up 'Replace in Files' dialog.Fixes issue #31146