Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Replace in Files" functionality to text editors (3.x) #55232

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 22, 2021

3.x version of #36044. This also incorporates #55233 for the Replace in Files dialog. Thanks @dreamsComeTrue for the original implementation 🙂

The Soft Reload Script shortcut was changed from Ctrl + Shift + R to Ctrl + Alt + R to avoid conflicts.

@Calinou Calinou requested a review from a team as a code owner November 22, 2021 16:12
@Calinou Calinou force-pushed the script-editor-add-replace-in-files-3.x branch 2 times, most recently from 76eab98 to 3b57ede Compare November 22, 2021 16:14
@Calinou Calinou added this to the 3.5 milestone Nov 22, 2021
@Calinou Calinou changed the title Add "Replace in Files" functionality to text editors Add "Replace in Files" functionality to text editors (3.x) Nov 22, 2021
The Soft Reload Script shortcut was changed from Ctrl + Shift + R
to Ctrl + Alt + R to avoid conflicts.
@Calinou Calinou force-pushed the script-editor-add-replace-in-files-3.x branch from 3b57ede to 7bd0eae Compare November 23, 2021 00:10
Copy link
Member

@lawnjelly lawnjelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, works fine in my tests so far. 👍

@akien-mga akien-mga merged commit f36debf into godotengine:3.x Dec 2, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the script-editor-add-replace-in-files-3.x branch December 2, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants