GDNative: Add bindings for the Packed*Array ptr() and ptrw() functions. #39064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah I agree. The Core API 1.0 relies on stuff which we're removing from the engine or renaming, so it needs a complete re-sync to match the 4.0 API 1:1 on release. Then we can re-add extensions for non-compat breaking additions in 4.1+. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bindings for the
Packed*Arrayread/write direct pointers (in place ofPoolVectorread_access and write_access helpers that were removed in #36311).Unrelated note: Since Core API binary compatibility was broken by #36311 and some subsequent changes, it might me worth to sort and consolidate all function to the new single "Core API 2.0", instead of maintaining multiple Core API extensions that are incompatible with 3.2 anyway.